Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dark mode changes to toolbar #1738

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Revert dark mode changes to toolbar #1738

merged 1 commit into from
Sep 28, 2023

Conversation

naschmitz
Copy link
Collaborator

The changes made it really difficult to see the icons in Colab. There isn't enough constrast with these thin icons.

Icons

@github-actions
Copy link

@github-actions github-actions bot temporarily deployed to pull request September 27, 2023 20:36 Inactive
@giswqs
Copy link
Member

giswqs commented Sep 28, 2023

I agree. This color issue should probably be resloved by the upstream ipywidgets package. There are some relevent issues there:

@giswqs giswqs merged commit 7dd93ef into master Sep 28, 2023
14 checks passed
@giswqs giswqs deleted the nschmitz-darkmode branch September 28, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants